Check if stock_item exists before adding variant to stock_location #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,7 +24,7 @@ def populate_for_supplier!(supplier) | |||
| variants_including_master.each do |variant| | |||
| unless variant.suppliers.pluck(:id).include?(supplier.id) | |||
| variant.suppliers << supplier | |||
| supplier.stock_locations.each { |location| location.propagate_variant(variant) } | |||
| supplier.stock_locations.each { |location| location.set_up_stock_item(variant) } | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only different between
propagate_variantandset_up_stock_itemis thatset_up_stock_itemchecks if a stock_item exist for this variant at this location before creating a new one. This has proven to be useful in various occasions for me - when setting up test objects, or when we set up the suppliers/products slightly differently. Without the check, if some how the stock_item already exists, rails gives a validation error like: Variant already exists.I've only tested it in 2-4, but doesn't seem to me this part of the code has changed much from 2-3 to 3-0, so probably safe to apply this to all of those branches.